Clone fallback audio tags instead of use ATL.Track.set #13694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The setter of the Track class is not intended for such use cases and will have unwanted side effects to change valid values. We should never use them use all fields from ATL.Track class read-only.
Shadowghost
approved these changes
Mar 10, 2025
Bond-009
approved these changes
Mar 11, 2025
crobibero
approved these changes
Mar 11, 2025
Bond-009
pushed a commit
that referenced
this pull request
Mar 12, 2025
Clone fallback audio tags instead of use ATL.Track.set Original-merge: 9eb2044 Merged-by: Bond-009 <bond.009@outlook.com> Backported-by: Bond_009 <bond.009@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setter of the
Trackclass is not intended for such use cases and will have unwanted side effects to change valid values. We should never use it and use all fields fromATL.Trackclass read-only.Changes
Issues
Fixes #13692