Skip to content

Clean up LocationManager warnings #13633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Clean up LocationManager warnings #13633

wants to merge 2 commits into from

Conversation

IDisposable
Copy link
Contributor

@IDisposable IDisposable commented Feb 28, 2025 •
edited
Loading

Changes
Fixed the warnings about missing ConfigureAwait(false) on the manifest stream processing.
Updated to current collection initialization pattern in LoadCultures

@Shadowghost
Copy link
Contributor

I'd appreciate if we can reduce the changes of this PR to the minimum - would also allow this to be against the release branch.

@IDisposable
Copy link
Contributor Author

Absolutely fine, I was not sure about targeting since this wasn't an urgent fix.

Would putting the Async updates in another PR be against release 10.x as well?

@Shadowghost
Copy link
Contributor

IMO those should go against master

@IDisposable
Copy link
Contributor Author

On it :)

@IDisposable
Copy link
Contributor Author

Ratings-only changes pulled into #13639

@IDisposable IDisposable mentioned this pull request Feb 28, 2025
Merged
@IDisposable
Clean up LocationManager warnings
009b592 
Cleaned up the ConfigureAwait suggestions.
Updated to current collection initialization pattern.
@IDisposable IDisposable force-pushed the localization-cleaning branch from 6ca7cc2 to 009b592 Compare February 28, 2025 18:48
@IDisposable IDisposable changed the title Accept "Rated: PG" like ratings Clean up LocationManager warnings Feb 28, 2025
@IDisposable
Copy link
Contributor Author

IDisposable commented Feb 28, 2025 •
edited
Loading

This PR now targets master with only the warning cleanups

Strongly recommend using the hide-whitespace option when reviewing :)

@IDisposable
Copy link
Contributor Author

@Shadowghost this PR now only does the warnings changes (the other PR for 10.x has been merged)v

@jellyfin-bot jellyfin-bot added the merge conflict Merge conflicts should be resolved before a merge label Mar 31, 2025
@jellyfin-bot
Copy link
Contributor

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@jellyfin-bot jellyfin-bot removed the merge conflict Merge conflicts should be resolved before a merge label Apr 1, 2025
@IDisposable
Copy link
Contributor Author

This is now a NOP after resolving conflicts. Closing

@IDisposable IDisposable closed this Apr 1, 2025
@IDisposable IDisposable deleted the localization-cleaning branch April 1, 2025 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bond-009 Bond-009 Bond-009 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IDisposable @Shadowghost @jellyfin-bot @Bond-009