Skip to content

Fix ParentIndexNumber when no Season folders are present #13610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix ParentIndexNumber when no Season folders are present #13610

wants to merge 2 commits into from

Conversation

DarkFighterLuke
Copy link

Changes
EpisodeServices MergeData method now merges ParentIndexNumber returned from remote providers if it is equal to 1 (which is a fallback value specified by the LibraryManager to make TMDB plugin work).

Issues
Fixes #13358

@JPVenson JPVenson added bug Something isn't working stable backport Backport into the next stable release confirmed This issue has been reviewed and confirmed labels Feb 24, 2025
nielsvanvelzen
nielsvanvelzen approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my (quick) testing this doesn't seem to introduce the buggy behavior we hunted for a while. Hopefully that stays the same when this is released and running on my production server.

@sjorge
Copy link

sjorge commented Feb 24, 2025

I did a few quick tests, this seems to fix #13197 for me.

(I ran dotnet build -c release, then copied over MediaBrowser.Providers.dll)

@Shadowghost
Copy link
Contributor

Shadowghost commented Feb 24, 2025 •
edited
Loading

I'm not convinced this is the right solution. IMO we should fix the TVDB plugin and remove the workaround. Because as it is right now, if the primary provider sets season to 1, any subsequent provider can override it.

@JPVenson
Copy link
Member

generally i agree with ghost.
As a compromise, quickfix it and then dont backport it and fix it correctly on master?

@sjorge
Copy link

sjorge commented Feb 24, 2025

generally i agree with ghost. As a compromise, quickfix it and then dont backport it and fix it correctly on master?

That runs the risk of 10.10.7+ to have it fixed, and 10.11.0+ not if it doesn't get fixed in master before the release is cut.

This was referenced Feb 24, 2025
Merged
Merged
@crobibero
Copy link
Member

Closing in favor of #13611

@crobibero crobibero closed this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

@JPVenson JPVenson JPVenson approved these changes

Assignees
No one assigned
Labels
bug Something isn't working confirmed This issue has been reviewed and confirmed stable backport Backport into the next stable release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DarkFighterLuke @sjorge @Shadowghost @JPVenson @crobibero @nielsvanvelzen