Skip to content

Prevent whitespaces in username during wizard setup #13604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 3, 2025
Merged

Prevent whitespaces in username during wizard setup #13604

merged 4 commits into from
Aug 3, 2025
+14 −5

Conversation

Jxiced
Copy link
Contributor

@Jxiced Jxiced commented Feb 21, 2025

Changes
Change UpdateUserAsync in UserManager to check for null user and to check against the valid username regex, preventing whitespace issues during wizard setup.

@Jxiced Jxiced mentioned this pull request Feb 21, 2025
Merged
@Jxiced
Copy link
Contributor Author

Jxiced commented Feb 21, 2025

jellyfin-web here: #6563

@JPVenson JPVenson added bug Something isn't working requires-web A server PR that requires a corresponding Web PR to be functional labels Feb 23, 2025
JPVenson
JPVenson approved these changes Feb 23, 2025
View reviewed changes
Copy link
Member

@JPVenson JPVenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idealy the api endpoint should validate this optimisticly

@Jxiced
Copy link
Contributor Author

Jxiced commented Feb 23, 2025 •
edited
Loading

Idealy the api endpoint should validate this optimisticly

Would something similar to these new changes be preferred?

@jellyfin-bot
Copy link
Contributor

ABI Difference 

MediaBrowser.Controller.dll
API compatibility errors between './abi-base/MediaBrowser.Controller.dll' (left) and './abi-head/MediaBrowser.Controller.dll' (right):
CP0006: Cannot add interface member 'void MediaBrowser.Controller.Library.IUserManager.ThrowIfInvalidUsername(string)' to ./abi-head/MediaBrowser.Controller.dll because it does not exist on ./abi-base/MediaBrowser.Controller.dll
API breaking changes found. If those are intentional, the APICompat suppression file can be updated by specifying the '--generate-suppression-file' parameter.

@jellyfin-bot jellyfin-bot added the merge conflict Merge conflicts should be resolved before a merge label Jul 4, 2025
@jellyfin-bot
Copy link
Contributor

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@joshuaboniface joshuaboniface merged commit ce78af2 into jellyfin:master Aug 3, 2025
9 of 13 checks passed
Bond-009 added a commit to Bond-009/jellyfin that referenced this pull request Aug 6, 2025
@Bond-009
Revert "Merge pull request jellyfin#13604 from Jxiced/master"
c7c7b30 
This reverts commit ce78af2, reversing
changes made to db7465e.
nielsvanvelzen added a commit that referenced this pull request Aug 7, 2025
@nielsvanvelzen
Merge pull request #14593 from Bond-009/revert
3762206 
Revert "Merge pull request #13604 from Jxiced/master"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JPVenson JPVenson JPVenson approved these changes

@crobibero crobibero crobibero approved these changes

Assignees
No one assigned
Labels
bug Something isn't working merge conflict Merge conflicts should be resolved before a merge requires-web A server PR that requires a corresponding Web PR to be functional
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Jxiced @jellyfin-bot @JPVenson @crobibero @joshuaboniface