Wait for ffmpeg to exit on Windows before we try deleting the concat file #13593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…file Fixes jellyfin#12145 without slowing down on other platform or for single files that don't need the concat file.
Shadowghost
approved these changes
Feb 20, 2025
crobibero
approved these changes
Feb 20, 2025
|
why not always wait for exit? Delay cannot be that more or? |
JPVenson
approved these changes
Feb 20, 2025
|
@JPVenson Why would we? Only Windows needs this workaround, I don't see why we should add delays into our code for platforms that don't need it. |
Bond-009
added a commit
that referenced
this pull request
Feb 25, 2025
Wait for ffmpeg to exit on Windows before we try deleting the concat file Original-merge: 346f36b Merged-by: Bond-009 <bond.009@outlook.com> Backported-by: Bond_009 <bond.009@outlook.com>
This was referenced Feb 25, 2025
Fix Issue #12145: Audio Normalization Scheduled Task temp file race condition causing failure
#12386
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12145 without slowing down on other platform or for single files that don't need the concat file.