Correctly handle audio number tag fallbacks #13490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although the number type is nullable from the type definition of ATL, the lib might still normalize all unknown values to 0 which makes doing null check only not enough. Fallback to ffprobe results when the number is 0 as well.
Shadowghost
reviewed
Feb 3, 2025
Comment on lines
+175
to
+177
| track.Year = track.Year is null or 0 ? mediaInfo.ProductionYear : track.Year; | ||
| track.TrackNumber = track.TrackNumber is null or 0 ? mediaInfo.IndexNumber : track.TrackNumber; | ||
| track.DiscNumber = track.DiscNumber is null or 0 ? mediaInfo.ParentIndexNumber : track.DiscNumber; |
There was a problem hiding this comment.
We usually don't use inline-linq like or in the code
There was a problem hiding this comment.
But in this case it is much cleaner than having nested assignments.
|
Doesnt't it also affect other fields? Like DATE/YEAR? |
|
We are only doing fallbacks for those limited fields for basic metadata as ffprobe has its own limitations. |
Bond-009
approved these changes
Feb 4, 2025
crobibero
approved these changes
Feb 4, 2025
117d208
into
jellyfin:release-10.10.z
15 of 16 checks passed
Bond-009
pushed a commit
that referenced
this pull request
Feb 9, 2025
Correctly handle audio number tag fallbacks Original-merge: 117d208 Merged-by: joshuaboniface <joshua@boniface.me> Backported-by: Bond_009 <bond.009@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the number type is nullable from the type definition of ATL, the lib might still normalize all unknown values to 0 which makes doing null check only not enough. Fallback to ffprobe results when the number is 0 as well.
Changes
Issues
Fixes #13484 without upstream changes so that the limited tags are falling back to ffprobe results. The complete fix is awaiting upstream release.