Don't select audio stream and codec explicitly for copy when bitrate exceeds limit #13423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exceeds limit Stream copy cannot be guaranteed when bitrate limit is exceeded, and the actual transcoding or copy is at best effort.
Shadowghost
approved these changes
Jan 25, 2025
Bond-009
approved these changes
Jan 25, 2025
crobibero
reviewed
Jan 25, 2025
Co-authored-by: Cody Robibero <cody@robibe.ro>
crobibero
approved these changes
Jan 25, 2025
Bond-009
pushed a commit
that referenced
this pull request
Feb 3, 2025
Don't select audio stream and codec explicitly for copy when bitrate exceeds limit Original-merge: e8514de Merged-by: crobibero <cody@robibe.ro> Backported-by: Bond_009 <bond.009@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stream copy cannot be guaranteed when bitrate limit is exceeded, and the actual transcoding or copy is at best effort. The explicit selection may result in a wrong fallback codec being picked up when a transcode has to happen.
Changes
Issues
Fixes #13416
Though I don't understand the reason why mp3 cannot be played on Android TV as the stream looks normal. This PR will make the fallback to pick AAC which should be played fine as verified by user.