Always await instead of directly returning Task #12925
Conversation
https://github.com/davidfowl/AspNetCoreDiagnosticScenarios/blob/master/AsyncGuidance.md#prefer-asyncawait-over-directly-returning-task The performance impact is negligible (and it's me saying that!)
|
Are there any downsides of this? When not, i will manually apply the patch :) |
|
Claiming "Nobody gives feedback" when there are two approvals is a bit weird. |
|
“Thumbs up” or ‘Approval’ is not a sign of ‘Yes it is noticeable, but it makes sense or yes we can stand behind it’. “Approval” here can primarily mean ‘Yep, the code doesn't seem to cause any problems, let's go for it’. I wanted to hear if anyone has effectively observed this from the devs etc. and possibly why it didn't make it into the releases as it still has a big performance impact? |
|
All arguments for/against this change are in the linked document. This is a really small change and there is no real reason to discuss anything about it. The performance penalty from this wouldn't be noticeable by a user anyway. |
https://github.com/davidfowl/AspNetCoreDiagnosticScenarios/blob/master/AsyncGuidance.md#prefer-asyncawait-over-directly-returning-task
The performance impact is negligible (and it's me saying that!)