Skip to content

Conversation

dkanada
Copy link
Member

@dkanada dkanada commented Oct 20, 2024

@nielsvanvelzen you requested the current behavior but it would change the status quo for existing clients.

Changes

Invert public boolean for backwards compatibility on clients that don't currently support this attribute. Currently untested so don't merge this unless it looks correct.

Issues

#12835

Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre 10.9 behavior would always create public playlists. To allow clients to adapt we kept that behavior with 10.9.
It should be fine to change it to private by default with 10.11 as that would've given client developers 2 releases / 1 year to migrate.

@crobibero crobibero merged commit 4c65e0d into jellyfin:master Nov 17, 2024
15 checks passed
@dkanada dkanada deleted the playlist-attributes branch November 18, 2024 00:39
Lampan-git pushed a commit to Lampan-git/jellyfin that referenced this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants