Skip to content

Implement TaskTriggerInfoType enum #12783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2024
Merged

Implement TaskTriggerInfoType enum #12783

merged 1 commit into from
Dec 2, 2024

Conversation

LePips
Copy link
Member

@LePips LePips commented Oct 6, 2024 •
edited
Loading

Just something I noticed while we're implementing tasks in Swiftfin. Not necessary for 10.10.

Changes
Implements TaskTriggerInfoType for the TaskTriggerInfo.Type field.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 6, 2024

Changes in OpenAPI specification found. Expand to see details.

What's Changed

POST /ScheduledTasks/{taskId}/Triggers
Request:

Changed content type : application/json

Changed items (object):
> Class TaskTriggerInfo.

  • Changed property Type (string -> string)

    Gets or sets the type.

Changed content type : text/json

Changed items (object):
> Class TaskTriggerInfo.

  • Changed property Type (string -> string)

    Gets or sets the type.

Changed content type : application/*+json

Changed items (object):
> Class TaskTriggerInfo.

  • Changed property Type (string -> string)

    Gets or sets the type.

GET /ScheduledTasks
Return Type:

Changed response : 200 OK

Scheduled tasks retrieved.

  • Changed content type : application/json

    Changed items (object):
    > Class TaskInfo.

    • Changed property Triggers (array)

      Gets or sets the triggers.

      Changed items (object):
      > Class TaskTriggerInfo.

      • Changed property Type (string -> string)

        Gets or sets the type.

  • Changed content type : application/json; profile="CamelCase"

    Changed items (object):
    > Class TaskInfo.

    • Changed property Triggers (array)

      Gets or sets the triggers.

      Changed items (object):
      > Class TaskTriggerInfo.

      • Changed property Type (string -> string)

        Gets or sets the type.

  • Changed content type : application/json; profile="PascalCase"

    Changed items (object):
    > Class TaskInfo.

    • Changed property Triggers (array)

      Gets or sets the triggers.

      Changed items (object):
      > Class TaskTriggerInfo.

      • Changed property Type (string -> string)

        Gets or sets the type.

GET /ScheduledTasks/{taskId}
Return Type:

Changed response : 200 OK

Task retrieved.

  • Changed content type : application/json

    • Changed property Triggers (array)

      Gets or sets the triggers.

      Changed items (object):
      > Class TaskTriggerInfo.

      • Changed property Type (string -> string)

        Gets or sets the type.

  • Changed content type : application/json; profile="CamelCase"

    • Changed property Triggers (array)

      Gets or sets the triggers.

      Changed items (object):
      > Class TaskTriggerInfo.

      • Changed property Type (string -> string)

        Gets or sets the type.

  • Changed content type : application/json; profile="PascalCase"

    • Changed property Triggers (array)

      Gets or sets the triggers.

      Changed items (object):
      > Class TaskTriggerInfo.

      • Changed property Type (string -> string)

        Gets or sets the type.

@jellyfin-bot
Copy link
Contributor

ABI Difference 

MediaBrowser.Model.dll
API compatibility errors between './abi-base/MediaBrowser.Model.dll' (left) and './abi-head/MediaBrowser.Model.dll' (right):
CP0002: Member 'string MediaBrowser.Model.Tasks.TaskTriggerInfo.TriggerDaily' exists on ./abi-base/MediaBrowser.Model.dll but not on ./abi-head/MediaBrowser.Model.dll
CP0002: Member 'string MediaBrowser.Model.Tasks.TaskTriggerInfo.TriggerWeekly' exists on ./abi-base/MediaBrowser.Model.dll but not on ./abi-head/MediaBrowser.Model.dll
CP0002: Member 'string MediaBrowser.Model.Tasks.TaskTriggerInfo.TriggerInterval' exists on ./abi-base/MediaBrowser.Model.dll but not on ./abi-head/MediaBrowser.Model.dll
CP0002: Member 'string MediaBrowser.Model.Tasks.TaskTriggerInfo.TriggerStartup' exists on ./abi-base/MediaBrowser.Model.dll but not on ./abi-head/MediaBrowser.Model.dll
CP0002: Member 'string MediaBrowser.Model.Tasks.TaskTriggerInfo.Type.get' exists on ./abi-base/MediaBrowser.Model.dll but not on ./abi-head/MediaBrowser.Model.dll
API breaking changes found. If those are intentional, the APICompat suppression file can be updated by specifying the '--generate-suppression-file' parameter.

@crobibero crobibero added the blocked Blocked by another pull request label Oct 14, 2024
@JPVenson
Copy link
Member

that would likely also break the webui right?

@LePips
Copy link
Member Author

LePips commented Oct 14, 2024 •
edited
Loading

No, as these are the only used trigger types. There used to be a StartupTrigger that was removed recently and the web hasn't been updated to accommodate that, but that type will now never be returned.

@crobibero crobibero removed the blocked Blocked by another pull request label Nov 30, 2024
@crobibero crobibero added the breaking change: plugin api Includes a breaking change for the plugin API label Nov 30, 2024
@crobibero crobibero merged commit 06923cb into jellyfin:master Dec 2, 2024
21 checks passed
Lampan-git pushed a commit to Lampan-git/jellyfin that referenced this pull request Feb 25, 2025
@LePips @Lampan-git
Implement TaskTriggerInfoType enum (jellyfin#12783)
aae3c81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shadowghost Shadowghost Shadowghost approved these changes

@JPVenson JPVenson JPVenson approved these changes

@Bond-009 Bond-009 Bond-009 approved these changes

@crobibero crobibero crobibero approved these changes

Assignees
No one assigned
Labels
breaking change: plugin api Includes a breaking change for the plugin API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LePips @jellyfin-bot @JPVenson @Shadowghost @Bond-009 @crobibero