Cleanup iPadOS ItemView TODOs
#1639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmomotiuk
approved these changes
Jul 14, 2025
LePips
requested changes
Jul 17, 2025
There was a problem hiding this comment.
@Environment(.horizontalSizeClass) ...@Environment(.verticalSizeClass)
We will eventually use the size classes more, like for determining the poster column counts.
Swiftfin/Views/ItemView/ScrollViews/iPadOSCinematicScrollView.swift
Outdated
Show resolved
Hide resolved
|
Last change while working on #1638. I found that 0.6 for iPad was blurring too much. I changed this to 0.5. See below as before and after. Let me know if this is unwanted and I can revert this: |
LePips
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Drops usages of
UIDevice.main.boundsin favor ofGeometryReader. Additionally, changes the trailing 200 padding between theOverviewandPlayButtonand with a more dynamic 5% of total screen size. This reduces the effective spacing on iPad when vertical and helps ensure that the spacing isn't too large.While working on this, I found that the Attributes almost always used 2 lines on the iPad Mini. Additionally, the
Genretext would often get pushed to 2 lines on iPad Mini. I changed theGenretext & others to always be on a single line to avoid issues. Altogether, I wanted to cleanup how the current version of this looked on the iPad Mini. This is how this looked prior to this PR:I've included various versions of how this looks now in this PR on both the iPad Mini (7.9") and iPad Pro (13") below for comparison.
Outstanding Questions
UIDevice.main.boundstoGeometryReader. In my research, this looked like the correct move. Please let me know if this is not.@Environment(\.horizontalSizeClass)and@Environment(\.verticalSizeClass). Right now, even the iPad Mini positioned vertically returns.regularso there's no real value I saw for this PR to use this. However, if we start allowing split screen for iPad,@Environment(\.horizontalSizeClass)can start to be used and will actually return.compactwhen split screen or in the side bar thing. Should I include this in this PR as a future looking item or should I hold off since there isn't a good way to test this?Screenshots
iPad Mini 7.9"- Vertical
iPad Mini 7.9" - Horizontal
iPad Pro 13" - Vertical
iPad Pro 13" - Horizontal