@LePips I think this is good to go! I've successfully migrated 10 different simulators and confirmed they are working as expected. I adding a lot of logging for this but please let me know if it's done incorrectly or needs to be scaled up/down. Most of the logging I use in my day-to-day are for logs only I see so please let me know if there is a more standard way I should be approaching this.

I've been testing this by loading everything onto a physical AppleTV. I will have the AppStore 1.0.1 version logged in and this branch logged in. I will then let both of these go into the background / close Swiftfin. I use VLC's tvOS to upload videos into the AppleTV's storage until it is full. Once it's full, I check both Swiftfins and find that 1.0.1 have been 'logged out' where the data has been cleared with the cache and this branch is still active and logged in.

Please let me know if there is a more scientific method for testing this. I know this route is kind of a pain but I've been testing this one for the day and this appears to have fixed the "log out" issue. Either that, or it's just more resilient? Regardless, I think you were right that this is the correct move for resolving this!

Finally, In my testing, the logic I have for the the tvOS SQLiteStore should be identical to what iOS is doing with the CoreStore defaults. However, I wanted to minimize impact so I left iOS intact as-is. Please let me know if that isn't the right move. Below is the item I am referring to:

    private static let storage: SQLiteStore = {

        let logger = Logging.Logger.swiftfin()

        let applicationSupportDirectory = FileManager.default.urls(
            for: .applicationSupportDirectory,
            in: .userDomainMask
        ).first!

        let databaseURL = applicationSupportDirectory.appendingPathComponent(bundleIdentifier, isDirectory: true)
            .appendingPathComponent("Swiftfin.sqlite")

        logger.info("Using the SQLite Database at: \(databaseURL.absoluteString)")

        #if os(tvOS)

        return SQLiteStore(
            fileURL: databaseURL,
            migrationMappingProviders: [Mappings.userV1_V2]
        )
        
        #else

        return SQLiteStore(
            fileName: "Swiftfin.sqlite",
            migrationMappingProviders: [Mappings.userV1_V2]
        )

        #endif
    }()

Please test after my changes to see if it still works.

Please test after my changes to see if it still works.

I'll start testing now but I will likely need a couple hours get to run through it all. I'll reach out when I am done!

@LePips

I haven't done any testing for the logout portion of this. I realize that we're using the same locations so this should not require new testing. However, our migration was failing. It was strange, the SQLite file was being moved over but none of the logged in accounts were there. The issue was the sqlite-wal wasn't moving over:

My understanding of the sqlite-wal is that this is just unprocessed transactions so this could just be that I am creating 1.0.1 then immediately attempting to migrate it, but IMO, this would make sense to move the the wal and shm over as well even if I don't believe the shm will impact anything. If anything, just to clean up after ourselves.

I added a commit that works in migrating these auxiliary files as well. I am only guarding on the SQLite since we only want to migrate the WAL and SHM if the SQLite moves so we're not mixing and matching auxiliary files.

I'm 100% sure you will have a better way of doing this than the [URL] haha. That being said, this latest commit works in resolving the migration portion of this. Please let me know if you need to me to test the logout portion again as well. I skipped this part since it's a slow test and we're using the same directories as prior but I'm not opposed if you feel it's warranted.

Building current main for tvOS seems to result in a broken Swiftfin atm, it just hangs at a spinner. I think it's due to this PR.

The dev console logs:
[🔴 Error] DataStack+Migration#244:addStorage(_:completion:) Failed to load SQLite 'NSPersistentStore' metadata.
[🔴 Error] SwiftfinStore#103:setupDataStack() Failed creating datastack with: The operation couldn’t be completed. (com.corestore.error error 5.)

When running on hardware (it previously had another Swiftfin tvOS installed build from main a week or so ago.

Running it in a simulator is fine though (but that one was empty)

Edit: removing swiftfin and rebooting the tvOS box results in the same and installing again results in the same.
Edit2: building 41d470e (the commit before this merge on main works fine)

@LePips I am so sorry, @sjorge is right... I swear I tested this in like 30 different ways but I must have missed something. Clean installs are screwing up on hardware.

I think is best to rollback while this is fresh. I can keep digging on my end to find a better route.

Sorry, I know that's a huge pain...

Glad I at least caught pretty quickly :) I try to bump my copy to main once a week or so.

#1660