[iOS] CinematicScrollView: Replace UIScreen bounds with GeometryReader #1646
Conversation
|
Looking again, this isn't quite right. The images are actually oversized because the GeometryReader proxy initially has zero size so the imageSource gets requested with a zero (unlimited) maxWidth. |
|
Now it only gets the imageSource when the GeometryReader's size is known, so the resolution is appropriate to the screen, and will be correct for both backdrop and poster images. I've also realized that the height multiplier should be 0.8 to get the exact same appearance as before, but I think both the backdrop and poster tend to look better at 0.6 |
There was a problem hiding this comment.
Thanks for taking a look at this. Having a static image size as I comment on iPadOS isn't much of a concern here since this is iOS. Also, taking a look at all of this again after so long makes me realize I may just combine what is currently the compact logo and cinematic views into a single view, and the user can then either make the image "larger" (what is currently cinematic), and still hide the logo. There, we would have a static size and I anticipate it would happen prior to the next release, so I'm okay with what this is for now.
Part of #1503's task replacing uses of UIScreen bounds.
The overall appearance is not significantly changed for either backdrop or poster images, and this incidentally fixes backdrop images being too low res and poster images extending too far down and obscuring the genre/year text.
Before & After (Backdrop)
Before & After (Poster)