Skip to content

Conversation

JPKribs
Copy link
Member

@JPKribs JPKribs commented Nov 27, 2024

Summary

Creates a menu to enable/disable access to a media library. Also allows for enable/disable access to deleting from a media library.

Getting very close to the end!

Screenshots

New Button New Button Screenshot
View 1 View 1 Screenshot
View 2 View 2 Screenshot

@JPKribs
Copy link
Member Author

JPKribs commented Nov 27, 2024

I think this is good to go unless there is a good binding extension for this scenario. #1323 has this scenario a few different places as well:

There is a list of potential options that should all be their own toggle that come from a datasource. When selected, they should be added to a [String] but when deselected, they should be removed from the [String].

Also, quirks:

  1. I am getting the media libraries from a .getLibraries call on the ServerUserAdminViewModel. I did this because MediaViewModel filters to only compatible libraries and for this instance I need all types. Should I make this it's own viewModel?
  2. I combined Media Access & Media Deletion into the same 'Media Access' view. Do we want these separated? I've already broken the mold from jellyfin-web by not including deletion into [iOS] Admin Dashboard - User Permissions #1313 and IMO Media Access & Media Deletion belong in the same spot but I'm game to change it if it makes more sense elsewhere.

Copy link
Member

@LePips LePips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just made a new Binding function for a contains, which I've seen other people use too.

You're really burning through these!

@LePips LePips merged commit 2ac9283 into jellyfin:main Dec 3, 2024
4 checks passed
@JPKribs JPKribs deleted the adminDashboardUserMediaDeletion branch December 3, 2024 11:50
@JPKribs JPKribs added the enhancement New feature or request label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants