Fix ContextMenu star menu clicking #987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves jeffvli#985. Currently, attempting to click on one of the `set rating` buttons is a no-op. This is because it is considered "outside" the `ContextMenu`, which immediately closes it. Pass in the same merged ref into the body of the `DropDown` component so that it is also treated as "inside". Making this a PR instead of just a push because I'm not sure if there are side effects.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #985.
Currently, attempting to click on one of the
set ratingbuttons is a no-op. This is because it is considered "outside" theContextMenu, which immediately closes it. Pass in the same merged ref into the body of theDropDowncomponent so that it is also treated as "inside".Making this a PR instead of just a push because I'm not sure if there are side effects.