Skip to content

fix: discord presence not clearing after pausing player #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 28, 2025

Conversation

Lyall-A
Copy link
Contributor

@Lyall-A Lyall-A commented Jun 27, 2025

Discord presence was not getting cleared when pausing the player unless it was the beginning of the track, it now clears if:

  • No current song
  • Player is paused
  • Beginning of track

Before:

  • No current song
  • Player is paused and beginning of track

Copy link

vercel bot commented Jun 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
feishin ❌ Failed (Inspect) Jun 28, 2025 8:38pm

@pyxfluff
Copy link
Contributor

There is a "paused" state in the RPC for a reason, you do not need to be clearing it. This should be an option if anything, not something I would really want forced on me

@Lyall-A
Copy link
Contributor Author

Lyall-A commented Jun 27, 2025

I guess it makes more sense when its set to show as "playing Feishin" on Discord, but I don't think it really makes sense when Show status as listening is enabled. Maybe it should depend on whether that setting is enabled or not

@Lyall-A
Copy link
Contributor Author

Lyall-A commented Jun 27, 2025

I've updated it to be an option instead, like the show idle option that was removed not long ago. I didn't actually realize that the paused state was intended, I just seen that it said I was listening to a track for 2 hours and assumed there was an issue so my bad. I still think this option should get added even if implemented some different way

@jeffvli jeffvli merged commit b6d902e into jeffvli:development Jun 28, 2025
5 checks passed
@Lyall-A Lyall-A deleted the fix-discord-rpc branch June 28, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants