The latest updates on your projects. Learn more about Vercel for Git ↗︎

Considering users using netease for lyric search only need a original version of lyric , adding netease_translate.ts may be a probable option

First of all, thank you for the PR.

This functionality is useful, but it needs to be configurable to be enabled/disabled since there are users who will not want to see the included translations.

Please add a settings option in the UI under lyric-settings, which includes storing the settings value under localSettings as well to access the value in the main process.

First of all, thank you for the PR.

This functionality is useful, but it needs to be configurable to be enabled/disabled since there are users who will not want to see the included translations.

Please add a settings option in the UI under lyric-settings, which includes storing the settings value under localSettings as well to access the value in the main process.

the setting option is easpecially for netease lyric(cuz only netease has translation lyric) and will it be confilicting with the existing api-translate option? So i wonder weather its suitable to add it globally in the lyric-settings (or merge it). And maybe we should ask @kgarner7 for further information.

You just need to make the new setting conditional based on if netease is selected as a lyric provider or not.

It should not conflict with any of the existing settings.

You just need to make the new setting conditional based on if netease is selected as a lyric provider or not.您只需要根据是否选择 netease 作为歌词提供商来制定新的条件即可。

It should not conflict with any of the existing settings.它不应该与任何现有设置冲突。

change enable netease translation for test，set false by default