fix(aqua): improve warnings for packages without repo_owner and repo_name (#5644) (2nd attempt) #6009
Conversation
…_owner a…" This reverts commit 11ecdca.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
bugbot run |
| } | ||
| } | ||
| Err(e) => { | ||
| warn!("Remote versions cannot be fetched: {}", e); |
There was a problem hiding this comment.
Bug: Unfiltered Version Listing Causes Installation Issues
The _list_remote_versions function in src/backend/aqua.rs now returns both normalized versions and raw tags without filtering for asset availability. This introduces duplicate entries and lists versions that are not installable, leading to misleading ls-remote output and potential installation failures if a non-installable version is selected.
There was a problem hiding this comment.
Pull Request Overview
This PR reverts changes made in #5668 and improves error handling for aqua packages that lack repo_owner and repo_name fields. The changes focus on better warning messages and handling version fetching failures more gracefully.
- Reverts previous error handling logic around version tag fetching
- Changes warning to a bail error for packages without repo metadata
- Simplifies version listing by avoiding complex package validation
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| .await | ||
| .ok() | ||
| .into_iter() | ||
| .flatten() |
There was a problem hiding this comment.
Using .ok() to silently ignore errors here means that version resolution failures won't be logged or handled, making debugging difficult when version fetching fails.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
We have a fallback so it's safe.
ac967fd to
ce881ad
Compare
### 📦 Registry - enable kubecolor test by [@risu729](https://github.com/risu729) in [#6008](#6008) - fix os specific backends for usage by [@risu729](https://github.com/risu729) in [#6007](#6007) - use aqua backend for restish by [@risu729](https://github.com/risu729) in [#5986](#5986) - add cfssljson ([aqua:cloudflare/cfssl/cfssljson](https://github.com/cloudflare/cfssl/cfssljson)) by [@disintegrator](https://github.com/disintegrator) in [#6013](#6013) - add claude-squad ([aqua:smtg-ai/claude-squad](https://github.com/smtg-ai/claude-squad)) by [@TyceHerrman](https://github.com/TyceHerrman) in [#5894](#5894) ### 🚀 Features - **(aqua)** make bin paths executable by [@risu729](https://github.com/risu729) in [#6010](#6010) - added header bar during `mise install` by [@jdx](https://github.com/jdx) in [#6022](#6022) ### 🐛 Bug Fixes - **(aqua)** improve warnings for packages without repo_owner and repo_name (2nd attempt) by [@risu729](https://github.com/risu729) in [#6009](#6009) - version prefix detection by [@risu729](https://github.com/risu729) in [#5943](#5943) - respect MISE_DEFAULT_CONFIG_FILENAME by [@risu729](https://github.com/risu729) in [#5899](#5899) ### New Contributors - @disintegrator made their first contribution in [#6013](#6013)
Reapplies #5644. Reverts #5668