Revert "fix(aqua): improve warnings for packages without repo_owner and repo_name (#5644)" #5668

jdx · 2025-07-17T14:57:10Z

This reverts commit ad36539.

…nd repo_name (#5644)" This reverts commit ad36539.

Copilot

Pull Request Overview

This PR reverts commit ad36539, which previously improved warnings for packages without repo_owner and repo_name. The revert changes error handling in the aqua backend by removing error propagation improvements and reverting the warning message format.

Reverts error handling changes in the _list_remote_versions method
Removes package validation logic for assets and error messages
Changes error handling from bail! back to warn! for missing repository information

Comments suppressed due to low confidence (1)

src/backend/aqua.rs:63

The variable name 'v' is ambiguous and unclear. Consider using a more descriptive name like 'version' for better code readability.

        for (v, tag) in version_tags.iter() {

Copilot · 2025-07-17T14:57:48Z

src/backend/aqua.rs

@@ -58,19 +58,15 @@ impl Backend for AquaBackend {
    }

    async fn _list_remote_versions(&self, _config: &Arc<Config>) -> Result<Vec<String>> {
-        let version_tags = self.get_version_tags().await;
+        let version_tags = self.get_version_tags().await?;


The revert removes error handling that was previously added. The ? operator will propagate errors up the call stack, but the previous version had explicit error handling with a warning message. Consider whether silent error propagation is the intended behavior.

Suggested change

let version_tags = self.get_version_tags().await?;

let version_tags = match self.get_version_tags().await {

Ok(tags) => tags,

Err(e) => {

eprintln!("Warning: Failed to fetch version tags: {}", e);

return Ok(Vec::new());

}

};

Copilot · 2025-07-17T14:57:49Z

src/backend/aqua.rs

-                        "aqua package {} does not have repo_owner and/or repo_name.",
-                        self.id
-                    );
+                    warn!("no aqua registry found for {}", self.ba());


The reverted warning message 'no aqua registry found for {}' is less specific than the previous error message that explicitly mentioned missing 'repo_owner and/or repo_name'. This makes debugging more difficult for users.

Suggested change

warn!("no aqua registry found for {}", self.ba());

warn!(

"no aqua registry found for {}: missing {}",

self.ba(),

if pkg.repo_owner.is_empty() && pkg.repo_name.is_empty() {

"repo_owner and repo_name"

} else if pkg.repo_owner.is_empty() {

"repo_owner"

} else {

"repo_name"

}

);

jdx · 2025-07-17T14:57:53Z

@risu729 this caused mise-versions to get a bunch of versions with a "v" prefix:

$ mise cache clear && MISE_USE_VERSIONS_HOST=0 cargo run ls-remote action-validator
0.1.0
v0.1.0
0.1.1
v0.1.1
0.1.2
v0.1.2
0.1.4
v0.1.4
0.2.0
v0.2.0
0.2.1
v0.2.1
0.3.0
v0.3.0
0.4.0
v0.4.0
0.5.0
v0.5.0
0.5.1
v0.5.1
0.5.2
v0.5.2
0.5.3
v0.5.3
0.5.4
v0.5.4
0.6.0
v0.6.0
0.7.1
v0.7.1

jdx · 2025-07-17T15:00:23Z

it's a weird bug I'm not sure is worth adding an e2e test around or not, I think we probably should since the "v" prefixing stuff has always caused issues. Maybe check to make sure all "action-validator" versions start with a digit?

If you look at the test-tools job in the latest release you can see this is failing on many tools

github-actions · 2025-07-17T15:10:51Z

Hyperfine Performance

`mise x -- echo`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`mise-2025.7.11 x -- echo`	17.8 ± 0.2	17.4	20.7	1.00
`mise x -- echo`	17.9 ± 0.3	17.4	21.3	1.01 ± 0.02

`mise env`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`mise-2025.7.11 env`	17.2 ± 0.2	16.8	18.0	1.00
`mise env`	17.5 ± 0.6	16.8	26.8	1.02 ± 0.04

`mise hook-env`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`mise-2025.7.11 hook-env`	17.0 ± 0.2	16.6	17.9	1.00
`mise hook-env`	17.1 ± 0.3	16.7	20.7	1.01 ± 0.02

`mise ls`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`mise-2025.7.11 ls`	15.1 ± 0.2	14.7	16.4	1.00
`mise ls`	15.1 ± 0.2	14.7	16.1	1.00 ± 0.02

`xtasks/test/perf`

Command	mise-2025.7.11	mise	Variance
install (uncached)	761ms	⚠️ 1088ms	-30%
install (cached)	125ms	124ms	+0%
ls (uncached)	694ms	694ms	+0%
ls (cached)	78ms	78ms	+0%
bin-paths (uncached)	696ms	⚠️ 987ms	-29%
bin-paths (cached)	64ms	66ms	-3%
task-ls (uncached)	3158ms	⚠️ 3586ms	-11%
task-ls (cached)	261ms	262ms	+0%

⚠️ Warning: install uncached performance variance is -30%
⚠️ Warning: bin-paths uncached performance variance is -29%
⚠️ Warning: task-ls uncached performance variance is -11%

@risu729

### 🐛 Bug Fixes - **(npm)** run bun in install_path instead of using --cwd flag of bun by [@risu729](https://github.com/risu729) in [#5656](#5656) - **(nushell)** fix `get -i` deprecation by [@JoaquinTrinanes](https://github.com/JoaquinTrinanes) in [#5666](#5666) ### ◀️ Revert - Revert "fix(aqua): improve warnings for packages without repo_owner and repo_name " by [@jdx](https://github.com/jdx) in [#5668](#5668) ### Chore - update deps by [@risu729](https://github.com/risu729) in [#5657](#5657) - update usage by [@risu729](https://github.com/risu729) in [#5661](#5661) ### New Contributors - @JoaquinTrinanes made their first contribution in [#5666](#5666)

risu729 · 2025-07-18T12:30:24Z

My apologies for the regression again.
I'll add a test, but I realized I don't understand about multiline strings in bash well, so I'll figure it out later.

…name (#5644) (2nd attempt) (#6009) Reapplies #5644. Reverts #5668

Revert "fix(aqua): improve warnings for packages without repo_owner a…

626755f

…nd repo_name (#5644)" This reverts commit ad36539.

Copilot AI review requested due to automatic review settings July 17, 2025 14:57

Copilot AI reviewed Jul 17, 2025

View reviewed changes

jdx enabled auto-merge (squash) July 17, 2025 14:58

jdx merged commit 11ecdca into main Jul 17, 2025
17 of 18 checks passed

jdx deleted the revert-aqua branch July 17, 2025 15:05

mise-en-dev mentioned this pull request Jul 17, 2025

chore: release 2025.7.12 #5658

Merged

mise-en-dev mentioned this pull request Jul 17, 2025

chore: release 2025.7.13 #5669

Merged

BrewTestBot mentioned this pull request Jul 17, 2025

mise 2025.7.12 Homebrew/homebrew-core#230412

Merged

risu729 mentioned this pull request Aug 13, 2025

fix(aqua): improve warnings for packages without repo_owner and repo_name (#5644) (2nd attempt) #6009

Merged

jdx pushed a commit that referenced this pull request Aug 13, 2025

fix(aqua): improve warnings for packages without repo_owner and repo_…

4674122

…name (#5644) (2nd attempt) (#6009) Reapplies #5644. Reverts #5668

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Revert "fix(aqua): improve warnings for packages without repo_owner and repo_name (#5644)" #5668

Revert "fix(aqua): improve warnings for packages without repo_owner and repo_name (#5644)" #5668

Uh oh!

jdx commented Jul 17, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jul 17, 2025

Uh oh!

Copilot AI Jul 17, 2025

Uh oh!

jdx commented Jul 17, 2025

Uh oh!

jdx commented Jul 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Jul 17, 2025

Uh oh!

risu729 commented Jul 18, 2025

Uh oh!

Uh oh!

-        let version_tags = self.get_version_tags().await?;
+        let version_tags = match self.get_version_tags().await {
+            Ok(tags) => tags,
+            Err(e) => {
+                eprintln!("Warning: Failed to fetch version tags: {}", e);
+                return Ok(Vec::new());
+            }
+        };

-                    warn!("no aqua registry found for {}", self.ba());
+                    warn!(
+                        "no aqua registry found for {}: missing {}",
+                        self.ba(),
+                        if pkg.repo_owner.is_empty() && pkg.repo_name.is_empty() {
+                            "repo_owner and repo_name"
+                        } else if pkg.repo_owner.is_empty() {
+                            "repo_owner"
+                        } else {
+                            "repo_name"
+                        }
+                    );

Uh oh!

Revert "fix(aqua): improve warnings for packages without repo_owner and repo_name (#5644)" #5668

Revert "fix(aqua): improve warnings for packages without repo_owner and repo_name (#5644)" #5668

Uh oh!

Conversation

jdx commented Jul 17, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

jdx commented Jul 17, 2025

Uh oh!

jdx commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 17, 2025

Hyperfine Performance

mise x -- echo

mise env

mise hook-env

mise ls

xtasks/test/perf

Uh oh!

risu729 commented Jul 18, 2025

Uh oh!

Uh oh!

jdx commented Jul 17, 2025 •

edited

Loading

`mise x -- echo`

`mise env`

`mise hook-env`

`mise ls`

`xtasks/test/perf`