build: Simplifying type generation process #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for anu-vue ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Thanks for the improvement ❤️ Everything is perfect as it should be. certainly, we can remove Awaiting your change 😇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few suggested changes:
npm run cleanscript: it will not remove node_modules folder, only removes dist folder. Advantage: you can avoid lengthy install process afternpm run cleandeep-cleanscript, which does remove the node_modules, but TBH I have never seen such approach in practice (aka removal of node_modules) elsewhere, so it's up to you whether to keep this or remove it as it's not really neededtsc --emitDeclarationOnly...as we have thedts()plugin in place which generates the d.ts files - advantage is a faster build and build script won't pollute the source folders with generated d.ts filestypesfolder. dts() plugin now generates types in that folder.LMK what you think