feat(btn): keyboard focus styles added via focus-visible #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for anu-vue ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
It looks great |
|
Sorry, I accidentally closed the PR 🙏🏻 Thanks for considering a11y. I just want to update the style here. I will let you know my updates and review the PR soon. |
|
Hi, I have made a few changes.
I hope you will like this. |
|
Hi @ManUtopiK I found that in dark mode we get some unwanted styles. If possible, can you please take a look? I have a really busy schedule these days. Thanks. |
jd-solanki
added a commit
to brojor/anu
that referenced
this pull request
Nov 27, 2022
Co-authored-by: JD Solanki <jdsolanki0001@gmail.com> Co-authored-by: JD Solanki <47495003+jd-solanki@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to work on focus in all element. I've started with the button component.
The focus follow the color of the button.
Here is a screenshot of the concept :
2022-10-23-18.16.47.474471455.mp4
Just for this screenshot, I added this css in
anu-vue/src/presets/theme-default/scss/index.scssto get a ring with 2px :Note that we have to add
!importantmark.It looks nice, but we cannot use it with css hex color or named color.
So I didn't change the style in lines 61 and 67.
We could use the opacity with the new css feature relative colors, but I don't know when it will be supported by major browsers...
In the meantime, I don't know what to do.
What do you think about ?