-
-
Notifications
You must be signed in to change notification settings - Fork 55
fix(typography): preserve typographyHeader reactivity #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(typography): preserve typographyHeader reactivity #49
Conversation
✅ Deploy Preview for anu-vue ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Thanks for the PR! You can reuse Feel free to update types of Thanks. |
Thanks, I didn't know about |
Yes, why not 😇 |
If possible, follow vueuse like convention: |
I just want to add export const useConfigurable = (value: MaybeRef<ConfigurableValue>) => computed(() => {
const _value = resolveUnref(value)
const [content, classes, attrs] = _value === undefined
? []
: typeof _value === 'string' || typeof _value === 'number'
? [_value]
: _value
return { content, classes, attrs }
}) |
make sure to test if we destructure via |
I thought that if we add |
Now it works (reactivity is preserved even when using I tried using |
Hi 👋🏻 Thanks for the useful PR I just removed the usage of Thanks so much |
Title and subtitle of
<ATypography />
are not reactive.Expected behavior:
Current behavior: