Skip to content

feat(checkbox): Add indeterminate state #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 6, 2022

Conversation

ManUtopiK
Copy link
Contributor

No description provided.

@jd-solanki
Copy link
Owner

jd-solanki commented Oct 9, 2022

Hi 👋🏻

I wanted to provide this feature as well but didn't get enough bandwidth and decided not to include it in essentials.

This is really nice except check icon still appears if we uncheck the checkbox as shown in below gif:
ezgif com-gif-maker

(GIF shows few frames from video hence in GIF check icon is clearly visible however in actual usage it still flashes the check icon)

Thanks.

@ManUtopiK
Copy link
Contributor Author

You can get clearly this glitch with the Animation Inspector in Chrome DevTools.
Fixed.

@jd-solanki
Copy link
Owner

jd-solanki commented Oct 11, 2022

Hi, I reviewed the PR and everything seems fine.

One thing I would like to ask is can you utilize code a bit so that we can omit next:checked in parent div and can also remove it from safelist

Awaiting your response.

@ManUtopiK
Copy link
Contributor Author

I'm too busy these days. I will do that at the end of the week...

@netlify
Copy link

netlify bot commented Oct 17, 2022

Deploy Preview for anu-vue ready!

Name Link
🔨 Latest commit ba0fe88
🔍 Latest deploy log https://app.netlify.com/sites/anu-vue/deploys/6367e14c9eb8920008b1e888
😎 Deploy Preview https://deploy-preview-40--anu-vue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ManUtopiK
Copy link
Contributor Author

ManUtopiK commented Oct 17, 2022

I don't know if I should rely on data ref() because there is no reactivity when there is no v-model like in DemoCheckboxColor.vue or DemoCheckboxIcon.vue. This both demos don't work in the last commit.

Should we specify modelValue required ?

@ManUtopiK
Copy link
Contributor Author

 Should we specify modelValue required ?

We could also just add a v-model in DemoCheckboxColor.vue or DemoCheckboxIcon.vue. Because in real world app development, it makes no sense to display a checkbox without react on it...

@jd-solanki jd-solanki changed the title feat(checkbox): Add indeterminate state + doc feat(checkbox): Add indeterminate state Nov 6, 2022
@jd-solanki jd-solanki merged commit 7a9ab96 into jd-solanki:main Nov 6, 2022
jd-solanki added a commit to brojor/anu that referenced this pull request Nov 27, 2022
Co-authored-by: JD Solanki <jdsolanki0001@gmail.com>
Co-authored-by: JD Solanki <47495003+jd-solanki@users.noreply.github.com>
@ManUtopiK ManUtopiK deleted the feat/checkboxIndeterminate branch December 1, 2022 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants