feat: Add reactivity to useDefaults & AConfig
#183
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for anu-vue failed.
|
e1e51d0 to
720b84d
Compare
720b84d to
800029b
Compare
|
Hi @IcetCode Thanks to your PR #165 & antfu's hint Anu now has props defaults with reactivity 🥳 Unfortunately, due to the updated API, we have to close #165 but I don't want to lose your work & contribution. We can merge this PR now but not without your credits, I'll wait for your contribution to this PR. I guess that small test is left compared to #165 Once we merge this we'll go on #156 and update it according to our discussion. Awaiting your updates 👀 |
|
You've really done a amazing work! I've added some tests to it, and I will try to see if we can provide a file in the playground to support |
|
closing in favor of #184 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related PR #165