fix(select): handle null & undefined as default values
#179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for anu-vue failed.
|
jd-solanki
reviewed
May 31, 2023
| @@ -107,7 +115,7 @@ function middleware() { | |||
| ref="selectRef" | |||
| readonly | |||
| class="a-select-input cursor-pointer" | |||
| :value="modelValue.text ?? modelValue" | |||
| :value="selectedValueText" | |||
There was a problem hiding this comment.
What if we change it to modelValue ? (modelValue.text ?? modelValue) : undefined
I guess this will probably work the same as the new changes but with less code
There was a problem hiding this comment.
Yep,it can be changed to this, I do this just for readability.
There was a problem hiding this comment.
Hey @IcetCode Can you please use props.modelValue instead of direct use of modelValue for future compatibility in template block? Anu defaults requires using props.x in template block.
There was a problem hiding this comment.
like this?
:value="props.modelValue ? props.modelValue.text ?? props.modelValue : undefined"null & undefined as default values
|
Thanks 😇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #178