feat!: assume display: inline-block as extraProperty in presetIcon
#16
Conversation
✅ Deploy Preview for anu-vue ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hey 👋🏻 Thanks for this PR :)
Yes, We do have
Yes, you are 💯 true here. To mitigate this best we can do is create our own VitePress theme or build the docs ourself. But both of them are overkill for now. The best I can think of is using I am planning to create a custom container for our docs which use ::: demo
demo description
::: raw
<DemoInputBasic />
:::
::: code
<<<@/...
:::
:::This will require a few hours to convert all demos. |
|
Moreover, to use that |
|
Do we need inline-block now in https://github.com/jd-solanki/anu/blob/49071628e12805944a67aa548cb6b28a7b47873e/packages/anu-vue/src/components/base-input/ABaseInput.tsx on line 67 & 87? |
That's so disappointing. |
No longer needed. |
display: inline-block default, resolve #9display: inline-block as extraProperty in presetIcon
I checked the following components, there is no any side effects when adding Add
display:inline-blockto extraProperties inpresetIcons. But I have a question,vitepresshas its own default style that overridesanu-vue, should we add a new playground to check it? For example, invitepress, input supports dark mode, but I don't support it in my own project. In fact,vitepressconfigures the default background of input to be transparent, which will confuse us into thinking thatanu-vuealso supports it.