fix: JBANG_JDK_VENDOR can again be used
#2113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2ab5de9 to
cea7b71
Compare
|
Should this be JBANG_JAVA_VENDOR ? ( Can still have the old as fallback but I'm inclined to have just one clean set of java-* settings) Wdyt? |
|
I don't mind, it's simple enough to do. |
|
+1 on making it JBANG_JAVA_VENDOR as that could translate well to |
The latest version of devkitman supports setting the "distro" of the JDK to install, which allows us to use the `JBANG_JDK_VENDOR` environment variable again to select the JDK vendor. Which was a feature that was missing since the switch to devkitman. (In devkitman the term "distro" was chosen instead of "vendor".)
c2d1b8b to
ef57449
Compare
maxandersen
approved these changes
Jul 26, 2025
|
I hadn't made the change yet :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of devkitman supports setting the "distro" of the JDK to install, which allows us to use the
JBANG_JDK_VENDORenvironment variable again to select the JDK vendor. Which was a feature that was missing since the switch to devkitman. (In devkitman the term "distro" was chosen instead of "vendor".)