feat: introduce clean docker multi java version build #1654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxandersen
commented
Jul 19, 2023
| ENV JBANG_VERSION {{projectVersion}} | ||
| ENV JBANG_PATH=/jbang/bin | ||
|
|
||
| VOLUME /scripts |
There was a problem hiding this comment.
might want to keep /scripts
maxandersen
commented
Jul 19, 2023
| ENV PATH="${PATH}:/jbang/bin" | ||
|
|
||
| ## github action does not allow writing to $HOME thus routing this elsewhere | ||
| ENV JBANG_DIR="/jbang/.jbang" |
There was a problem hiding this comment.
need to check if this is still required.
6c7200b to
73896f7
Compare
Why: * jbang-action is hardcoded to use a specific java version requiring users to download new java version * nicer if can have a docker images that has the java version built in This change addreses the need by: * move jbang-action to a separate distribution (might consider dropping it fully) * add a jbang-docker repo that builds a docker image with jbang and java and publishes under jbangdev/jbang:<version>-java-<java major version>.
24583b0 to
01d2f9c
Compare
|
merging this to see if can make it all work :) wish the next release luck! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
requiring users to download new java version
built in
This change addreses the need by:
and publishes under jbangdev/jbang:-java-.