-
-
Notifications
You must be signed in to change notification settings - Fork 629
feat: Add macOS 14 ARM 64 runners to the matrix #2132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebase this once #2145 is in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI macos-latest
already runs arm64
. So the current patch doesn't change the runtime.
The idea of #2079 is to have both arm64
and intel
jobs in CI.
Although, we have to be mindful of the CI resources as this would be computationally expensive. We need to be strategic about this and perhaps have two variants on cron and on merge rather than in PRs, for example.
This needs more research to be implemented correctly.
@sirosen it should be doable to take over this and merge before the release. |
I wonder if x86-64 this still makes sense with GH taking away the native test env from FOSS: actions/runner-images#12520. |
After reading the runner-images thread, I looked at some other CI services to see if GitHub is an outlier here. It seems that there's a broader mass migration off of support for Intel Macs. For example, this was CircleCI's announcement thread for removal of x86-64. My current thinking is that we may have to accept the loss of a testing platform here, and hope that our coverage is still good enough. We're already in a version of this position given that our CI runs only on I'm undecided about what to do with this PR exactly. I would like to be intentional about changing the job names if we're doing that (which this currently does). And I'm overall not sure what my position is around use of |
Yep, I want static version identifiers, not We might either lose |
fix: #2079
Contributor checklist
Maintainer checklist
backwards incompatible
,feature
,enhancement
,deprecation
,bug
,dependency
,docs
orskip-changelog
as they determine changelog listing.