Skip to content

Conversation

dycw
Copy link
Contributor

@dycw dycw commented Jun 7, 2022

As per title; fixes #1615.

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few comments.

@@ -389,7 +389,7 @@ If you have multiple requirement files make sure you create a hook for each file
files: ^requirements-lint\.(in|txt)$
- id: pip-compile
name: pip-compile requirements.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: pip-compile requirements.txt
name: pip-compile requirements.in

Input file is requirements.in.

@dycw dycw closed this by deleting the head repository Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc suggests pre-commit hook should run with requirements.txt
2 participants