Skip to content

Fix test failures on Windows #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2024
Merged

Fix test failures on Windows #707

merged 1 commit into from
Mar 11, 2024

Conversation

SpecLad
Copy link
Contributor

@SpecLad SpecLad commented Mar 5, 2024

_get_prof_file_name did not work correctly when the file separator was not /.

@SpecLad
Fix test failures on Windows
5467194 
`_get_prof_file_name` did not work correctly when the file separator
was not `/`.
50-Course
50-Course approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@50-Course 50-Course left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

-        filename = file_path.rsplit('/')[-1]
+        filename = os.path.basename(file_path)

LGTM

@50-Course 50-Course merged commit 1cb4623 into jazzband:master Mar 11, 2024
@SpecLad SpecLad deleted the fix-windows-tests branch March 11, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@50-Course 50-Course 50-Course approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SpecLad @50-Course