Remove source requirement, sniff .ts or .tsx, add multi-entry #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i have just migrated to 0.3.0 and it works fine except for the one issue i filed. thanks for the dx/readme improvements too! |
|
We’re getting there! Thanks for the help! |
7 tasks
joeflateau
pushed a commit
to joeflateau/tsdx
that referenced
this pull request
Nov 12, 2021
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty awful PR, and I think I am going to refactor the codebase again. However, I need to think through how multiple entries will work with dev/prod builds and entry points. Anyways, this PR closes #27, #26, #23, #19, #16
--format cjs,umd,es--entry src/index.ts(and I think even--entry src/**.tswill work)sourceinpackage.json, although it will still work. Instead TSDX will defaults tosrc/index.tsorsrc/index.tsx(it sniffs the file ending).dist/index.js.Todo:
TESTS!