(optim/test): use node testEnvironment #405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- default is jsdom, which we don't need - also fix missing newline at EOF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default is jsdom, which we don't need
also fix missing newline at EOF
Wrote this a while ago, but decided not to PR earlier as it didn't speed up tests at all locally o.o Figured I should PR it now as it's related to #396 , can decide whether to close or merge now.
I guess this is still good to have for correctness of tests, even if doesn't actually optimize anything. It might optimize windows tests on CI, as those seem to be slower than the rest but 🤷♂
Also think this will be the last of my PRs for the day, was really on a roll today getting in lots of changes I had in-progress 😅 (though most of them were small)