Skip to content

CI: make sure the lockfile is up-to-date #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Conversation

RalfJung
Copy link
Collaborator

@RalfJung RalfJung commented Nov 8, 2019

@jethrogb This seems like a useful thing to do on CI?

@RalfJung
Copy link
Collaborator Author

RalfJung commented Nov 8, 2019

This is odd, CI should have failed because the lockfile actually isn't up-to-date...

@jethrogb
Copy link
Collaborator

jethrogb commented Nov 8, 2019

Are you sure --locked works properly when the only changes are not related to dependencies? There's also --frozen but I never know the difference.

@RalfJung
Copy link
Collaborator Author

RalfJung commented Nov 8, 2019

A cargo build --locked locally failed when I prepared this PR.

But maybe cross breaks --locked?

@RalfJung
Copy link
Collaborator Author

Turns out that yes, this is a cross issue and they are working on it.

Meanwhile, no reason not to land this here so that we get the fix once cross is fixed -- @jethrogb what do you think?

@RalfJung
Copy link
Collaborator Author

There's also --frozen but I never know the difference.

--frozen implies --locked, but also refuses to download new crates into cargo's cache (it's basically "offline mode").

@RalfJung
Copy link
Collaborator Author

The cross issue is fixed; I will land this here.

bors r+

bors bot added a commit that referenced this pull request Nov 22, 2019
264: CI: make sure the lockfile is up-to-date r=RalfJung a=RalfJung

@jethrogb This seems like a useful thing to do on CI?

Co-authored-by: Ralf Jung <post@ralfj.de>
@bors
Copy link
Contributor

bors bot commented Nov 22, 2019

Build succeeded

@bors bors bot merged commit 9725ed4 into japaric:master Nov 22, 2019
@RalfJung RalfJung deleted the locked branch December 8, 2019 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants