retryScreenshot for more Robust screenshot loop #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonjmcghee
reviewed
May 4, 2024
stopScreenCapture fail retries Co-authored-by: Jason McGhee <mcghee.j@gmail.com>
|
Yup good addition! |
|
Added in a db busyTimeout of 2 seconds. Main reason is being more robust to external applications locking the db |
jasonjmcghee
reviewed
May 4, 2024
rem/DB.swift
Outdated
| @@ -59,6 +59,9 @@ class DatabaseManager { | |||
| db = try! Connection("db.sqlite3") | |||
| } | |||
|
|
|||
| // 2 second busy timeout | |||
| db.busyTimeout = 2000 | |||
There was a problem hiding this comment.
My initial reaction to this is- we're not doing writes from outside, just reads right? We should just support concurrent reads. Maybe something like:
try db.run("PRAGMA journal_mode = WAL")
// Maybe?
try db.run("PRAGMA synchronous = NORMAL")
jasonjmcghee
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now when the retrieval of the DisplayID or Display fails, the screenshot process is reattempted up to 3 times in a row.
This should help prevent silent exiting of the screenshot loop.