Skip to content

MacOS standard settings window. Fix issue#39 #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 31, 2023
Merged

MacOS standard settings window. Fix issue#39 #42

merged 1 commit into from
Dec 31, 2023

Conversation

caetano-dev
Copy link
Contributor

@caetano-dev caetano-dev commented Dec 31, 2023 •
edited
Loading

This PR fixes #39 by letting the user open the settings window when pressing cmd + ,

It also adds a keyEquivalent to the menu.
Capture d’écran 2023-12-31 à 14 48 56

@caetano-dev caetano-dev mentioned this pull request Dec 31, 2023
Closed
@jasonjmcghee
Copy link
Owner

This is a great change and I’ll merge it regardless, but @seletz does this fix #39 in your eyes or are more changes needed?

@jasonjmcghee jasonjmcghee merged commit 5f76458 into jasonjmcghee:main Dec 31, 2023
@jasonjmcghee
Copy link
Owner

@caetano-dev thank you!! you're making rem better for everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonjmcghee jasonjmcghee jasonjmcghee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Settings Window Does Not Use MacOS Standard
2 participants
@caetano-dev @jasonjmcghee