Skip to content

JaneObjectNormalizer::getSupportedTypes is now produced multiline #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2024
Merged

JaneObjectNormalizer::getSupportedTypes is now produced multiline #821

merged 1 commit into from
Jul 29, 2024

Conversation

Korbeil
Copy link
Member

@Korbeil Korbeil commented Jul 29, 2024

Fixes #816

@dkarlovi
Copy link
Contributor

Since the map is basically repeating the other map, would it be possible to create them from the same source, so we DRY?

@Korbeil
Copy link
Member Author

Korbeil commented Jul 29, 2024

Since the map is basically repeating the other map, would it be possible to create them from the same source, so we DRY?

Sadly this is not the same output so we cannot do that.

@Korbeil Korbeil force-pushed the fix/issue-816 branch 3 times, most recently from 09fddef to ededfcd Compare July 29, 2024 13:49
@Korbeil Korbeil merged commit 6d79f1c into next Jul 29, 2024
8 checks passed
@Korbeil Korbeil deleted the fix/issue-816 branch July 29, 2024 14:12
@dkarlovi dkarlovi mentioned this pull request Nov 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JaneObjectNormalizer::getSupportedTypes needs to be produced multiline same as normalizers before
2 participants
@Korbeil @dkarlovi