Skip to content

fix: add Symfony command configure() void return, avoid deprecations #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 3, 2024
Merged

fix: add Symfony command configure() void return, avoid deprecations #811

merged 3 commits into from
Jul 3, 2024

Conversation

dkarlovi
Copy link
Contributor

@dkarlovi dkarlovi commented Jul 2, 2024 •
edited
Loading

Closes #804

lyrixx
lyrixx approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍🏼

@Korbeil
Copy link
Member

Korbeil commented Jul 3, 2024

Could you add a quick note about your change in the CHANGELOG ? 🙏

@dkarlovi
Copy link
Contributor Author

dkarlovi commented Jul 3, 2024

@Korbeil done.

@Korbeil Korbeil merged commit 8139004 into janephp:next Jul 3, 2024
@dkarlovi dkarlovi deleted the fix/deprecations branch July 3, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Korbeil Korbeil Korbeil approved these changes

+1 more reviewer

@lyrixx lyrixx lyrixx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecations for GenerateCommand::configure()
3 participants
@dkarlovi @Korbeil @lyrixx