Skip to content

Cast integer data to bool for boolean fields #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2025
Merged

Cast integer data to bool for boolean fields #846

merged 1 commit into from
Apr 4, 2025

Conversation

gisostallenberg
Copy link
Contributor

No description provided.

@Korbeil
Copy link
Member

Korbeil commented Apr 4, 2025

Could you add a regression test for your fix please @gisostallenberg ? 🙏
Also, a little line about this change in the CHANGELOG file would be appreciated

@gisostallenberg gisostallenberg force-pushed the cast-integer-data-to-bool-for-boolean-fields branch 2 times, most recently from 37ed1da to 92b7cbe Compare April 4, 2025 15:15
@gisostallenberg
Copy link
Contributor Author

gisostallenberg commented Apr 4, 2025 •
edited
Loading

@Korbeil

Also, a little line about this change in the CHANGELOG file would be appreciated

What category do I need to put there?

@Korbeil
Copy link
Member

Korbeil commented Apr 4, 2025

Since it's a change in JsonSchema, I would put [JsonSchema] there.
Also if you're talking about the Added/Changed/Fixed, I would say it's a fix, since it should have been that way from the beginning.

@gisostallenberg
Copy link
Contributor Author

Ok!

The most notable change in the tests is in src/Component/JsonSchema/Tests/Validation/ValidationTest.php:698.

@gisostallenberg gisostallenberg force-pushed the cast-integer-data-to-bool-for-boolean-fields branch from 92b7cbe to 767c0c2 Compare April 4, 2025 15:22
@gisostallenberg
Copy link
Contributor Author

I think all issues are resolved

Korbeil
Korbeil approved these changes Apr 4, 2025
View reviewed changes
Copy link
Member

@Korbeil Korbeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks for your contribution @gisostallenberg !

@gisostallenberg
Copy link
Contributor Author

Thanks for your time!!

@Korbeil Korbeil merged commit 8ee9a29 into janephp:next Apr 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Korbeil Korbeil Korbeil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gisostallenberg @Korbeil