Skip to content

Add PHP 8.4 Support #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 17, 2025
Merged

Add PHP 8.4 Support #843

merged 5 commits into from
Apr 17, 2025

Conversation

MikeSepteo
Copy link

  • update for PHP 8.4
  • remove dead code & useless dependencies
  • update dependencies
  • migrate phpunit configuration
  • fix unit tests

@kinamike
bugfix:
e67996e 
* Fix Reference Normalizer not working with Symfony 7.2.x
* Run php-cs-fixer for PHP 8.4
@kinamike
feature:
78de38c 
* update for PHP 8.4
* remove dead code & useless dependencies
* update dependencies
* migrate phpunit configuration
* fix unit tests
@MikeSepteo MikeSepteo mentioned this pull request Jan 20, 2025
Closed
@func0der
Copy link
Contributor

@MikeSepteo Would you update your to resolve the conflicts, please?
I think it has a higher chance of getting merged then :)

Thanks for the PR

Korbeil
Korbeil approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@Korbeil Korbeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR ! @MikeSepteo 🙏

@Korbeil Korbeil merged commit 932ad4c into janephp:next Apr 17, 2025
6 checks passed
@MikeSepteo
Copy link
Author

Sorry for the late answer, i was working hard on other projects 🧑‍🏭

@Korbeil
Copy link
Member

Korbeil commented Apr 22, 2025

It's fine, I handled all the things and merged this PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Korbeil Korbeil Korbeil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MikeSepteo @func0der @Korbeil @kinamike