Skip to content

PHP 8.4 & Symfony 7.2.x support #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2025
Merged

PHP 8.4 & Symfony 7.2.x support #842

merged 1 commit into from
Jan 23, 2025

Conversation

MikeSepteo
Copy link

@MikeSepteo MikeSepteo commented Jan 17, 2025 •
edited
Loading

Add Support of PHP 8.4 & Symfony 7.2.x

Fixes

  • Fix Reference Normalizer not working with Symfony 7.2.x
  • Run php-cs-fixer for PHP 8.4

Closes: #840

@MikeSepteo MikeSepteo mentioned this pull request Jan 17, 2025
Closed
@Korbeil
Copy link
Member

Korbeil commented Jan 18, 2025

Hey, thanks for the pull request @MikeSepteo, I see there is some CS issue, could you run the php-cs-fixer please ? 🙏

@MikeSepteo MikeSepteo force-pushed the bugfix/fix-symfony-serializer-implementation branch from 176e7e0 to 5e707ad Compare January 20, 2025 17:10
Korbeil
Korbeil approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@Korbeil Korbeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

@Korbeil
Copy link
Member

Korbeil commented Jan 21, 2025

Could you add a quick note about your changes in the CHANGELOG please ?

@MikeSepteo MikeSepteo force-pushed the bugfix/fix-symfony-serializer-implementation branch from 5e707ad to c2b5d82 Compare January 21, 2025 15:25
@kinamike
bugfix:
60230d7 
* Fix Reference Normalizer not working with Symfony 7.2.x
* Run php-cs-fixer for PHP 8.4
* update changelog
@MikeSepteo MikeSepteo force-pushed the bugfix/fix-symfony-serializer-implementation branch from c2b5d82 to 60230d7 Compare January 21, 2025 15:38
Korbeil
Korbeil approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@Korbeil Korbeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect, thanks ! 🙏

@Korbeil Korbeil merged commit 81706cb into janephp:next Jan 23, 2025
4 checks passed
@MikeSepteo MikeSepteo deleted the bugfix/fix-symfony-serializer-implementation branch January 28, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Korbeil Korbeil Korbeil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP 8.4 & Symfony 7.2.x support
3 participants
@MikeSepteo @Korbeil @kinamike