Skip to content

Add discriminator support to anyOf #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 23, 2024
Merged

Conversation

FilipBenco
Copy link
Contributor

@FilipBenco FilipBenco commented May 20, 2023

Add support for discriminators used with anyOf inside Schemas.

@FilipBenco FilipBenco marked this pull request as ready for review May 20, 2023 11:15
@FilipBenco
Copy link
Contributor Author

@Korbeil Hi, would you have time to look into this PR? :)

Copy link
Member

@Korbeil Korbeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @FilipBenco, sorry for the (too long) delay and thanks for this contribution !
For my own culture, the related documentation is here: https://swagger.io/docs/specification/data-models/inheritance-and-polymorphism/

Could you add a note about this change in the CHANGELOG file ?
Once that is done I'll merge it 🙏

@AlexOstrovsky
Copy link

@Korbeil whats the status of this?

@Korbeil
Copy link
Member

Korbeil commented Jun 23, 2024

Just me not forgetting to click 😱 Deeply sorry for the wait, I'll merge it now.

@Korbeil Korbeil merged commit 14906f5 into janephp:next Jun 23, 2024
@AlexOstrovsky
Copy link

Thank you. @Korbeil when can we expect new release?

@Korbeil
Copy link
Member

Korbeil commented Jun 27, 2024

And done @AlexOstrovsky !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants