Skip to content

Move PHP CS Fixer to a separate composer.json file #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Move PHP CS Fixer to a separate composer.json file #748

merged 2 commits into from
Aug 24, 2023

Conversation

jmsche
Copy link
Contributor

@jmsche jmsche commented Aug 17, 2023

Hi, this PR moves the PHP CS Fixer requirement from the main composer.json file to a separate one, allowing to install latest version of PHP CS Fixer.

I added some new rules to keep tests working, so the changes are as small as possible :)

@Korbeil
Copy link
Member

Korbeil commented Aug 19, 2023

Thanks for your contribution @jmsche ! Could you add a little note in the CHANGELOG file about your changes ?

@jmsche
Copy link
Contributor Author

jmsche commented Aug 21, 2023

Added changelog entry 👍

@Korbeil
Copy link
Member

Korbeil commented Aug 24, 2023

Thanks !

@Korbeil Korbeil merged commit cec6b43 into janephp:next Aug 24, 2023
@jmsche jmsche deleted the move-php-cs-fixer branch October 9, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants