fix(AutoMapper): MapToContext should accept virtual properties #741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
107769d to
1a0e49c
Compare
nikophil
commented
Jul 10, 2023
| @@ -65,4 +77,21 @@ private function allParametersHaveMapToContextAttribute(\ReflectionMethod $metho | |||
|
|
|||
| return true; | |||
| } | |||
|
|
|||
| private function isAllowedProperty(string $class, string $property, bool $writeAccessRequired = false): bool | |||
There was a problem hiding this comment.
stolen directly in ReflectionExtractor
1fada0a to
5123f97
Compare
5123f97 to
8ec10b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm just not really sure about the strategy I used to make the service
MapToContextPropertyInfoExtractorDecoratoravailable: I don't want to decorateReflectionExtractorin the whole app, this is a little bit too intrusiveAnother solution would be to declare a new property extractor service specific to the automapper.