Skip to content

Add buffer/from-bytes #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2023
Merged

Add buffer/from-bytes #1259

merged 1 commit into from
Aug 18, 2023

Conversation

primo-ppcg
Copy link
Contributor

Filling a lexical gap, to avoid things like this:

(buffer (string/from-bytes ;data))
(buffer/push-byte @"" ;data)

or even this:

(def buf @"")
(each b data
  (buffer/push-byte buf b))

Adding this function has increased the size of the executable by 32 bytes on my system:
master:

$ du -b `which janet`
801384	/usr/local/bin/janet

branch:

$ du -b `which janet`
801416	/usr/local/bin/janet

Of course, it's also faster than either alternative:

(use spork/test)

(var data (range 65 91))

(timeit-loop [:timeout 1]
  (buffer/from-bytes ;data))

(timeit-loop [:timeout 1]
  (buffer (string/from-bytes ;data)))

(timeit-loop [:timeout 1]
  (buffer/push-byte @"" ;data))
buffer/from-bytes 1.000s, 0.1529µs/body
string/from-bytes 1.000s, 0.2261µs/body
buffer/push-byte  1.000s, 0.2637µs/body

@sogaiu
Copy link
Contributor

sogaiu commented Aug 18, 2023

Here's what I got:

$ JANET_PATH=~/src/spork/jpm_tree/lib ~/src/janet.primo-ppcg/build/janet ~/scratch/buffer-from-bytes.janet 
Elapsed time: 1.000s, 0.2079µs/body
Elapsed time: 1.001s, 0.2947µs/body
Elapsed time: 1.000s, 0.3522µs/body

pepe
pepe approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@pepe pepe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bakpakin bakpakin merged commit f3969b6 into janet-lang:master Aug 18, 2023
@primo-ppcg primo-ppcg deleted the buffer-from-bytes branch August 18, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@pepe pepe pepe approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@primo-ppcg @sogaiu @pepe @bakpakin