Skip to content

Conversation

sogaiu
Copy link
Contributor

@sogaiu sogaiu commented Jun 22, 2023

This PR contains a suggestion to use vm_commit(); in place of janet_stack_frame(stack)->pc = pc;.

The vm_commit(); construct is used elsewhere within the JOP_CALL handling in which this instance of janet_stack_frame(stack)->pc = pc; appears:

Perhaps it makes sense to use vm_commit(); on line 983 as well?

Though I can see that if one wanted to leave the JANET_FUNCTION-handling parts of JOP_CALL and JOP_TAILCALL easier to compare, perhaps not using vm_commit(); might be preferrable.

@bakpakin
Copy link
Member

LGTM

@bakpakin bakpakin merged commit c3f4dc0 into janet-lang:master Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants