Fix info statistics argument name in README.md #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandelgado
reviewed
Sep 14, 2024
Makefile
Outdated
| @@ -7,7 +7,7 @@ TOXICMD:=docker compose exec toxiproxy /go/bin/toxiproxy-cli | |||
| .PHONY: phony | |||
|
|
|||
| build: phony | |||
| CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -ldflags \ | |||
There was a problem hiding this comment.
please don't change - I don't use a mac. if absoultely needed, make GOOS and GOARCH overwritable with e.g. GOOS ?= linux and GOARCH ?= amd64 so they can be set during invocation of make.
There was a problem hiding this comment.
Ah, sorry, I did not intend to include this change into the pull request. It should only include the README fix. Updated.
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small fix of the README.md.