remove stripping of absolute path for SF key #10
Conversation
|
Hi, thanks for the PR. While I think it's always good to go with the specification, i think we should make the behaviour of using the full-path opt-in, since it will be an incompatible change, leading to different lcov files. So could you please make it optional by adding a |
| @@ -213,7 +191,6 @@ func parseCoverage(coverage io.Reader) (map[string][]*block, error) { | |||
| log.Printf("warn: %v", err) | |||
| continue | |||
| } | |||
| f = getCoverallsSourceFileName(f) | |||
There was a problem hiding this comment.
pass this function as a parameter. Default is to pass getCoverallsSourceFileName, if -use-absolute-source-path is set, just pass identify, which keeps the original, absolute path, e.g. func identity(f) string {return f;}
632e4a9 to
afa09ec
Compare
|
Looks good thank you. I'll check why the CI fails later today ... |
|
Please rebase to master and let's see if the inttest passes now without problems |
The lcov spec wants the SF attribute to contain an absolute path to the source file, thus far a relative one has been used which breaks some tools that use the lcov file. When using the -use-absolute-source-path argument the lcov output will contain the full absolute path.
afa09ec to
26b01e0
Compare
The format wants an absolute path for the SF key as specified here under
the FILES section: http://ltp.sourceforge.net/coverage/lcov/geninfo.1.php
(and as I've just seen you have that in your README too)
Some programs will accept and work with relative paths with or without
./ but there's also a good chance to fail. Thus abiding by the spec is
the best idea.