-
Notifications
You must be signed in to change notification settings - Fork 59
Fix #79, #54, and #83 #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I noticed one small annoyance where clicking on the code requirement text field removes the truncation (...). The only way I found to prevent that is making the text field non-selectable, but I think we prefer that text field be selectable so you can highlight parts of it and copy paste. |
Added the fix for #83 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The UI changes look good to me!
Changes the following property names to reflect their names in System Preferences: All Files > Full Disk Access Address Book > Contacts Calendar > Calendars Listen Event > Input Monitoring Screen Capture > Screen Recording Added MDM Keys to the help button for each property (ProfilesDescriptions.swift) Rearranged the new property names alphabetically and updated the backgrounds
After a discussion with @watkyn, I opted to rename a few more properties to better reflect their counterparts under System Preferences > Security & Privacy. The MDM Key name was then added to the help text next to each property. |
Resources/Base.lproj/Main.storyboard
Outdated
@@ -972,7 +982,7 @@ | |||
<subviews> | |||
<textField horizontalHuggingPriority="251" verticalHuggingPriority="750" translatesAutoresizingMaskIntoConstraints="NO" id="VVZ-4w-pac"> | |||
<rect key="frame" x="8" y="17" width="227" height="16"/> | |||
<textFieldCell key="cell" lineBreakMode="clipping" alignment="left" title="All Files:" id="V29-FR-cfE"> | |||
<textFieldCell key="cell" lineBreakMode="clipping" alignment="left" title="Full Disk Access" id="V29-FR-cfE"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far we have stuck with the MDM keys for the labels. But the issue #79 makes a good point that people are more familiar with the verbiage from System Preferences on the Mac and not the MDM spec.
So we should probably change all the labels over to the equivalent names in System Preferences if we are going to make this change? The other thing that we should do then, is in the help for each item, we should add the text (MDM key: SystemPolicyAllFiles) so a user can know how they are mapped to the MDM side.
Thoughts?
Added to the code requirement label:
Updated All Files to Full Disk Access