Skip to content

Conversation

ty-wilson
Copy link
Contributor

Added to the code requirement label:

truncates
maximum of 2 lines
tooltip binding
padding on right edge

Updated All Files to Full Disk Access

ty-wilson and others added 9 commits May 19, 2020 09:49
Merge pull request jamf#57 from ty-wilson/master
Fix the save workflow so that the keychain prompt displays after the …
Add a changelog and update the readme (jamf#78)
Merging latest updates
Added to the code requirement label:
> truncates
> maximum of 2 lines
> tooltip binding
> padding on right edge
Updated All Files to Full Disk Access
Revert Code Signing Identity
@ty-wilson
Copy link
Contributor Author

I noticed one small annoyance where clicking on the code requirement text field removes the truncation (...). The only way I found to prevent that is making the text field non-selectable, but I think we prefer that text field be selectable so you can highlight parts of it and copy paste.

Bind the Apple Events Table Selection Index to the AppleEventsAC Selection Index
@ty-wilson ty-wilson closed this Oct 23, 2020
@ty-wilson ty-wilson reopened this Oct 23, 2020
@ty-wilson ty-wilson changed the title Fix #79 and #54 Fix #79, #54, and #83 Oct 23, 2020
@ty-wilson
Copy link
Contributor Author

Added the fix for #83

Copy link
Contributor

@hisaac hisaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI changes look good to me!

Changes the following property names to reflect their names in System Preferences:
All Files > Full Disk Access
Address Book > Contacts
Calendar > Calendars
Listen Event > Input Monitoring
Screen Capture > Screen Recording

Added MDM Keys to the help button for each property (ProfilesDescriptions.swift)

Rearranged the new property names alphabetically and updated the backgrounds
@ty-wilson ty-wilson requested a review from hisaac October 29, 2020 23:59
@ty-wilson
Copy link
Contributor Author

After a discussion with @watkyn, I opted to rename a few more properties to better reflect their counterparts under System Preferences > Security & Privacy. The MDM Key name was then added to the help text next to each property.
All Files > Full Disk Access
Address Book > Contacts
Calendar > Calendars
Listen Event > Input Monitoring
Screen Capture > Screen Recording

@ty-wilson ty-wilson mentioned this pull request Oct 30, 2020
@@ -972,7 +982,7 @@
<subviews>
<textField horizontalHuggingPriority="251" verticalHuggingPriority="750" translatesAutoresizingMaskIntoConstraints="NO" id="VVZ-4w-pac">
<rect key="frame" x="8" y="17" width="227" height="16"/>
<textFieldCell key="cell" lineBreakMode="clipping" alignment="left" title="All Files:" id="V29-FR-cfE">
<textFieldCell key="cell" lineBreakMode="clipping" alignment="left" title="Full Disk Access" id="V29-FR-cfE">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far we have stuck with the MDM keys for the labels. But the issue #79 makes a good point that people are more familiar with the verbiage from System Preferences on the Mac and not the MDM spec.

So we should probably change all the labels over to the equivalent names in System Preferences if we are going to make this change? The other thing that we should do then, is in the help for each item, we should add the text (MDM key: SystemPolicyAllFiles) so a user can know how they are mapped to the MDM side.

Thoughts?

@watkyn watkyn merged commit f34bf8f into jamf:master Nov 2, 2020
ty-wilson added a commit to ty-wilson/PPPC-Utility that referenced this pull request Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing an Apple Event always removes the first item Properties Verbiage Long code signing requirements are not fully displayed
3 participants