-
Notifications
You must be signed in to change notification settings - Fork 59
113 connection to jamf pro should be updated to use bearer tokens #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
113 connection to jamf pro should be updated to use bearer tokens #114
Conversation
…eing a valid type to use for our purposes.
…e and make a unit test for it.
…files for better consistency.
If anybody can tell me what exactly SwiftLint is complaining about with the 6 |
… of comments in URLSessionAsyncCompatibility.
I updated the GitHub action that runs SwiftLint to the latest version, modified a couple of comments in the code, and now it's happy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@macblazer nice to see the async await changes and I think they all look great.
I did notice one issue in testing, which was an error "Jamf Pro Server is unavailable" when I tried an earlier version of Jamf Pro (10.21.0). This happened during the "Check Connection" button pressed.
Not sure which version cutoff it was for bearer tokens, but if you can double check how far back we want to support for Jamf Pro.
…c authorization. Added unit tests of the NetworkAuthManager code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Refactored some of the code around the networking, such as making a
SemanticVersion
type and moving the configuration profile API payload generation out of the networking code and over to theTCCProfile
type.Using async-await style network connections, and using an
actor
to synchronize getting/refreshing a bearer token.Fixes #113