Skip to content

Conversation

macblazer
Copy link
Contributor

@macblazer macblazer commented Jun 22, 2022

Refactored some of the code around the networking, such as making a SemanticVersion type and moving the configuration profile API payload generation out of the networking code and over to the TCCProfile type.

Using async-await style network connections, and using an actor to synchronize getting/refreshing a bearer token.

Fixes #113

@macblazer
Copy link
Contributor Author

If anybody can tell me what exactly SwiftLint is complaining about with the 6 orphaned_doc_comment errors I would be happy to fix it. The errors in GitHub action log don't have line numbers or even filenames associated with them, and locally SwiftLint v0.47.1 is happy with the code.

… of comments in URLSessionAsyncCompatibility.
@macblazer
Copy link
Contributor Author

I updated the GitHub action that runs SwiftLint to the latest version, modified a couple of comments in the code, and now it's happy.

Copy link
Contributor

@watkyn watkyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@macblazer nice to see the async await changes and I think they all look great.

I did notice one issue in testing, which was an error "Jamf Pro Server is unavailable" when I tried an earlier version of Jamf Pro (10.21.0). This happened during the "Check Connection" button pressed.

Not sure which version cutoff it was for bearer tokens, but if you can double check how far back we want to support for Jamf Pro.

…c authorization. Added unit tests of the NetworkAuthManager code.
Copy link
Contributor

@watkyn watkyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@macblazer macblazer merged commit 35e8b47 into jamf:master Jul 5, 2022
@macblazer macblazer deleted the 113-connection-to-jamf-pro-should-be-updated-to-use-bearer-tokens branch July 5, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connection to Jamf Pro should be updated to use Bearer Tokens
2 participants